Skip to content

fix(core): Fixes piped input parser on decrypt #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix(core): Fixes piped input parser on decrypt #224

merged 1 commit into from
Jul 10, 2024

Conversation

@dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Jul 10, 2024 •
edited
Loading

  • don't skip newline characters
  • tested locally with replace directive from internal project
  • This is causing failures when decrypting piped input if the TDF bytes happens to contain one of a small set of stop characters - which is very likely for larger files but not too likely for very small files so we hadn't noticed

@dmihalcik-virtru
fix(core): Fixes piped input parser on decrypt
0ed9483 
- don't skip newline characters
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner July 10, 2024 14:37
@jakedoublev
Copy link
Contributor

jakedoublev commented Jul 10, 2024

what was the error this was causing? reformatting of text?

@dmihalcik-virtru
Copy link
Member Author

dmihalcik-virtru commented Jul 10, 2024

Added more detail. Basically, the previous method for converting from os.stdin to a []byte was not sound

ntrevino-virtru
ntrevino-virtru approved these changes Jul 10, 2024
View reviewed changes
Copy link

@ntrevino-virtru ntrevino-virtru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throwing a ✅ hoping mine is strong enough 💪

@dmihalcik-virtru dmihalcik-virtru merged commit a375ddb into main Jul 10, 2024
@dmihalcik-virtru dmihalcik-virtru deleted the fix/scanner-readly branch July 10, 2024 18:10
@opentdf-automation opentdf-automation bot mentioned this pull request Jun 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntrevino-virtru ntrevino-virtru ntrevino-virtru approved these changes

@jakedoublev jakedoublev jakedoublev approved these changes

@jrschumacher jrschumacher Awaiting requested review from jrschumacher

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmihalcik-virtru @jakedoublev @ntrevino-virtru